Fix release build - remove streamlit installation in Dockerfile #867
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 628874e in 8 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. Dockerfile:12
- Draft comment:
Ensure that any dependencies or scripts relying on Streamlit are also removed or updated, as the Streamlit installation has been removed. - Reason this comment was not posted:
Confidence changes required:50%
The removal of the Streamlit installation seems intentional, but we need to ensure that any dependencies or scripts relying on Streamlit are also removed or updated.
Workflow ID: wflow_6ZxYmlGgkDq7EWOM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
wintonzheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Remove Streamlit installation and related entrypoint script from Dockerfile.
pip install streamlitcommand.COPYandchmodcommands forentrypoint-streamlit.sh.This description was created by
for 628874e. It will automatically update as commits are pushed.